• John Kacur's avatar
    agp: Remove the BKL from agp_open · 55e858c8
    John Kacur authored
    - Remove the BKL from agp_open
    - Perform a few clean-ups.
    
    Analysis:
    ---------
    int minor is local to the function.
    
    The following are protected by agp_fe.agp_mutex
    struct agp_file_private *priv;
    struct agp_client *client;
    
    Call-outs:
    
    kzalloc should be safe to call under the mutex_lock
    
    agp_find_client_by_pid:
    	- agp_mmap calls that under agp_fe.agp_mutex which we hold in agp_open
    	- agpioc_reserve_wrap calls it without any locking what-so-ever.
    		- Is that an error? Or is that okay because it has pid that is
    		  a unique handle?
    
    agp_insert_file_private:
    	- This function only manipulates struct agp_file_private, once again
    	  while agp_fe.agp_mutex is held
    Signed-off-by: default avatarJohn Kacur <jkacur@redhat.com>
    Acked-by: default avatarDavid Airlie <airlied@linux.ie>
    LKML-Reference: <alpine.LFD.2.00.0910112216060.12574@localhost.localdomain>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    55e858c8
frontend.c 24.1 KB