• Mark Brown's avatar
    omapfb: Fix regulator API abuse in dss.c and hdmi4/5.c · 1d1e56f4
    Mark Brown authored
    The voltage changing code in this driver is broken and should be
    removed.  The driver sets a single, exact voltage on probe.  Unless
    there is a very good reason for this (which should be documented in
    comments) constraints like this need to be set via the machine
    constraints, voltage setting in a driver is expected to be used in cases
    where the voltage varies at runtime.
    
    In addition client drivers should almost never be calling
    regulator_can_set_voltage(), if the device needs to set a voltage it
    needs to set the voltage and the regulator core will handle the case
    where the regulator is fixed voltage.  If the driver can skip setting
    the voltage it should just never set the voltage.
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    [tomi.valkeinen@ti.com: fix abuse in hdmi5.c too]
    Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
    1d1e56f4
hdmi4.c 16.6 KB