• Mathieu Desnoyers's avatar
    x86: revert replace LOCK_PREFIX in futex.h · 1f49a2c2
    Mathieu Desnoyers authored
    Since we now use DS prefixes instead of NOP to remove LOCK prefixes,
    there are no longer any issues with instruction boundaries moving around.
    
    Depends on :
    
    x86 alternatives : fix LOCK_PREFIX race with preemptible kernel and CPU hotplug
    
    On Thu, 14 Aug 2008, Mathieu Desnoyers wrote:
    >
    > Changing the 0x90 (single-byte nop) currently used into a 0x3E DS segment
    > override prefix should fix this issue. Since the default of the atomic
    > instructions is to use the DS segment anyway, it should not affect the
    > behavior.
    
    Ok, so I think this is an _excellent_ patch, but I'd like to also then use
    LOCK_PREFIX in include/asm-x86/futex.h.
    
    See commit 9d55b992.
    
                    Linus
    
    Applies to 2.6.27-rc2 (and -rc3 unless hell broke loose in futex.h between rc2
    and rc3).
    Signed-off-by: default avatarMathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    CC: Linus Torvalds <torvalds@linux-foundation.org>
    CC: H. Peter Anvin <hpa@zytor.com>
    CC: Jeremy Fitzhardinge <jeremy@goop.org>
    CC: Roland McGrath <roland@redhat.com>
    CC: Ingo Molnar <mingo@elte.hu>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    CC: Steven Rostedt <srostedt@redhat.com>
    CC: Thomas Gleixner <tglx@linutronix.de>
    CC: Peter Zijlstra <peterz@infradead.org>
    CC: Andrew Morton <akpm@linux-foundation.org>
    CC: David Miller <davem@davemloft.net>
    CC: Ulrich Drepper <drepper@redhat.com>
    CC: Rusty Russell <rusty@rustcorp.com.au>
    CC: Gregory Haskins <ghaskins@novell.com>
    CC: Arnaldo Carvalho de Melo <acme@redhat.com>
    CC: "Luis Claudio R. Goncalves" <lclaudio@uudg.org>
    CC: Clark Williams <williams@redhat.com>
    CC: Christoph Lameter <cl@linux-foundation.org>
    CC: Andi Kleen <andi@firstfloor.org>
    CC: Harvey Harrison <harvey.harrison@gmail.com>
    Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
    1f49a2c2
futex.h 3.34 KB