• Arnd Bergmann's avatar
    staging: ccree: add CRYPTO dependency · 3d51b956
    Arnd Bergmann authored
    A rare randconfig build error shows up when we have CONFIG_CRYPTO=m
    in combination with a built-in CCREE driver:
    
    crypto/hmac.o: In function `hmac_update':
    hmac.c:(.text.hmac_update+0x28): undefined reference to `crypto_shash_update'
    crypto/hmac.o: In function `hmac_setkey':
    hmac.c:(.text.hmac_setkey+0x90): undefined reference to `crypto_shash_digest'
    hmac.c:(.text.hmac_setkey+0x154): undefined reference to `crypto_shash_update'
    drivers/staging/ccree/ssi_cipher.o: In function `ssi_blkcipher_setkey':
    ssi_cipher.c:(.text.ssi_blkcipher_setkey+0x350): undefined reference to `crypto_shash_digest'
    drivers/staging/ccree/ssi_cipher.o: In function `ssi_blkcipher_exit':
    ssi_cipher.c:(.text.ssi_blkcipher_exit+0xd4): undefined reference to `crypto_destroy_tfm'
    drivers/staging/ccree/ssi_cipher.o: In function `ssi_blkcipher_init':
    ssi_cipher.c:(.text.ssi_blkcipher_init+0x1b0): undefined reference to `crypto_alloc_shash'
    drivers/staging/ccree/ssi_cipher.o: In function `ssi_ablkcipher_free':
    ssi_cipher.c:(.text.ssi_ablkcipher_free+0x48): undefined reference to `crypto_unregister_alg'
    drivers/staging/ccree/ssi_cipher.o: In function `ssi_ablkcipher_alloc':
    ssi_cipher.c:(.text.ssi_ablkcipher_alloc+0x138): undefined reference to `crypto_register_alg'
    ssi_cipher.c:(.text.ssi_ablkcipher_alloc+0x274): undefined reference to `crypto_blkcipher_type'
    
    We actually need to depend on both CRYPTO and CRYPTO_HW here to avoid the
    problem, since CRYPTO_HW is a bool symbol and by itself that does not
    force CCREE to be a loadable module when the core cryto support is modular.
    
    Fixes: 50cfbbb7 ("staging: ccree: add ahash support")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-By: default avatarGilad Ben-Yossef <gilad@benyossef.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    3d51b956
Kconfig 1.2 KB