• Stanislaw Gruszka's avatar
    i915: remove pm_qos request on error · 22accca0
    Stanislaw Gruszka authored
    Not removing pm qos request and free memory for it can cause crash,
    when some other driver use pm qos. For example, this oops:
    
    BUG: unable to handle kernel paging request at fffffffffffffff8
    IP: [<ffffffff81307a6b>] plist_add+0x5b/0xd0
    Call Trace:
     [<ffffffff810acf25>] pm_qos_update_target+0x125/0x1e0
     [<ffffffff810ad071>] pm_qos_add_request+0x91/0x100
     [<ffffffffa053ec14>] e1000_open+0xe4/0x5b0 [e1000e]
    
    was caused by earlier i915 probe failure:
    
    [drm:i915_report_and_clear_eir] *ERROR* EIR stuck: 0x00000010, masking
    [drm:init_ring_common] *ERROR* render ring initialization failed ctl 0001f001 head 00003004 tail 00000000 start 00003000
    [drm:i915_driver_load] *ERROR* failed to init modeset
    i915: probe of 0000:00:02.0 failed with error -5
    
    Bug report:
    http://bugzilla.redhat.com/show_bug.cgi?id=1057533Reported-by: default avatarGiandomenico De Tullio <ghisha@gmail.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
    [danvet: Drop unnecessary code movement.]
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    22accca0
i915_dma.c 52.5 KB