• Jia-Ju Bai's avatar
    net: phy: phy_led_triggers: Fix a possible null-pointer dereference in... · 271da132
    Jia-Ju Bai authored
    net: phy: phy_led_triggers: Fix a possible null-pointer dereference in phy_led_trigger_change_speed()
    
    In phy_led_trigger_change_speed(), there is an if statement on line 48
    to check whether phy->last_triggered is NULL:
        if (!phy->last_triggered)
    
    When phy->last_triggered is NULL, it is used on line 52:
        led_trigger_event(&phy->last_triggered->trigger, LED_OFF);
    
    Thus, a possible null-pointer dereference may occur.
    
    To fix this bug, led_trigger_event(&phy->last_triggered->trigger,
    LED_OFF) is called when phy->last_triggered is not NULL.
    
    This bug is found by a static analysis tool STCheck written by
    the OSLAB group in Tsinghua University.
    Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    271da132
phy_led_triggers.c 3.92 KB