• Emmanuel Grumbach's avatar
    iwlwifi: mvm: don't set the drain bit when we flush the AP station · 2775613f
    Emmanuel Grumbach authored
    When we disassociate in managed mode, we flush the queues
    after mac80211 has already removed the station.
    During that time, the pointer to ieee80211_sta to the
    fw_id_to_mac_id map is -EINVAL. In that case we should not
    set the station as being drained when the last Tx of this
    station has exited the shared Tx queue since we are
    flushing all the queues anyway.
    The draining logic is meant to be used in GO / AP mode only.
    In GO / AP mode, we set -EBUSY in the fw_id_to_mac_id map.
    
    This is why testing the ieee80211_sta pointer in the
    fw_id_to_mac_id map with IS_ERR isn't enough to set the
    station as draining, we need to check that it is -EBUSY.
    
    The only impact of the bug was a print:
    
    Drained sta 1, but it is internal?
    Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
    Reviewed-by: default avatarJohannes Berg <johannes.berg@intel.com>
    2775613f
tx.c 27.8 KB