• Alexander Strakh's avatar
    V4L/DVB (13379): quickcam_messenger: possible buffer overflow while use strncat · 2b588db8
    Alexander Strakh authored
    In driver ./drivers/media/video/usbvideo/quickcam_messenger.c in line 91:
    
      91         usb_make_path(dev, cam->input_physname, sizeof(cam->input_physname));
    
    After this line we use strncat:
    
      92         strncat(cam->input_physname, "/input0", sizeof(cam->input_physname));
    
    where sizeof(cam->input_physname) returns length of cam->input_phisname
    without length for null-symbol.  But this parameter must be - "maximum
    numbers of bytes to copy", i.e.:
    sizeof(cam->input_physname)-strlen(cam->input_physname)-1.
    
    In this case, after call to usb_make_path the similar drivers use strlcat.
    
    Like in: drivers/hid/usbhid/hid-core.c:
    1152         usb_make_path(dev, hid->phys, sizeof(hid->phys));
    1153         strlcat(hid->phys, "/input", sizeof(hid->phys));
    
    Found by Linux Driver Verification Project.
    
    Use strlcat instead of strncat.
    Signed-off-by: default avatarAlexander Strakh <strakh@ispras.ru>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    2b588db8
quickcam_messenger.c 26.8 KB