• Tomi Valkeinen's avatar
    drm/omap: fix omap_framebuffer_unpin() error handling · 9c368506
    Tomi Valkeinen authored
    omap_framebuffer_unpin() check the return value of omap_gem_put_paddr()
    and return immediately if omap_gem_put_paddr() fails.
    
    This patch removes the check for the return value, and also removes the
    return value of omap_framebuffer_unpin(), because:
    
     * Nothing checks the return value of omap_framebuffer_unpin(), and even
       something did check it, there's nothing the caller can do to handle
       the error.
    
     * If a omap_gem_put_paddr() fails, the framebuffer's other planes will
       be left unreleased. So it's better to call omap_gem_put_paddr() for
       all the planes, even if one would fail.
    Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
    Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
    9c368506
omap_fb.c 12.6 KB