• Yinghai Lu's avatar
    PCI: pciehp: Disable/enable link during slot power off/on · 2debd928
    Yinghai Lu authored
    On a system with a repeater on the system board to support gen2 hotplug,
    we found that when an ExpressModule is removed from some slots,
    /var/log/messages will be full of "card present/not present" warnings.
    
    It turns out the root complex is continually trying to train the link to
    the repeater because the repeater has not been reset.
    
    This patch will disable the link at removal time to allow the repeater
    to be reset properly.  This also prevents a potential AER message at
    removal time.
    
    Also, when testing hotplug on a system under development, we found if we
    boot the system without an EM installed, and later hot-add an EM, it
    does not work with Linux, but another OS is ok.  The root cause is that
    BIOS left link disabled when slot was empty at boot time, and other OS
    is modifying the link disable bit in link ctrl during power on/off.
    
    So we should do the same thing to disable/enable link during power off/on.
    
    -v2: check link DLLA bit instead of 100ms waiting.
         Separate link disable/enable functions to another patch.
    Signed-off-by: default avatarYinghai Lu <yinghai.lu@oracle.com>
    Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    2debd928
pciehp_hpc.c 25.1 KB