• Jesper Juhl's avatar
    [PATCH] OSS: cs46xx cleanup and tiny bugfix · 2eebb192
    Jesper Juhl authored
    Here's a patch for cs46xx that
     - (mostly) cleans up the cs46xx driver according to CodingStyle
     - removes a bunch of pointless casts
     - fixes a small, potential use of uninitialized variable, bug
     - reduces the size of the compiled code by 36 bytes
     - reduces the size of the source file by 1831 bytes
    
    I know I should probably have split this into bits, but since I only
    thought of that *after* doing all the edits, splitting it up would have
    been a royal pain. And since these are all pretty trivial changes I thought
    I'd just submit the one huge patch and hope people could live with it (if
    not, then just tell me and I'll split it).
    
    The bug fix that's in there may be hard to spot, so I'll point it out. It's
    the
       -       int val, valsave, mapped, ret;
       +       int val, valsave, ret;
       +       int mapped = 0;
    bit.
    Without that change we may use `mapped' uninitialized if, in cs_ioctl, the
    first test of "if(state)" is false and the second "if(state)" test is true.
    Signed-off-by: default avatarJesper Juhl <jesper.juhl@gmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    2eebb192
cs46xx.c 157 KB