• Andrey Smirnov's avatar
    tools/firmware/ihex2fw: Simplify next record offset calculation · 2ef8179b
    Andrey Smirnov authored
    We can convert original expression for 'writelen" to use ALIGN as
    follows:
    
        (p->len + 9) & ~3 => (p->len + 6 + 3) & ~3 => ALIGN(p->len + 6, 4)
    
    Now, subsituting "p->len + 6" with "p->len + sizeof(p->addr) +
    sizeof(p->len)" we end up with the same expression as used by kernel
    couterpart in linux/ihex.h:
    
        ALIGN(p->len + sizeof(p->addr) + sizeof(p->len), 4)
    
    That is a full size of the record, aligned to 4 bytes. No functional
    change intended.
    
    Cc: Chris Healy <cphealy@gmail.com>
    Cc: Kyle McMartin <kyle@kernel.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
    Cc: David Woodhouse <dwmw2@infradead.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: linux-kernel <linux-kernel@vger.kernel.org>
    Signed-off-by: default avatarAndrey Smirnov <andrew.smirnov@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    2ef8179b
ihex2fw.c 6.84 KB