• Peter Zijlstra's avatar
    sched/fair: Fix fairness issue on migration · 2f950354
    Peter Zijlstra authored
    Pavan reported that in the presence of very light tasks (or cgroups)
    the placement of migrated tasks can cause severe fairness issues.
    
    The problem is that enqueue_entity() places the task before it updates
    time, thereby it can place the task far in the past (remember that
    light tasks will shoot virtual time forward at a high speed, so in
    relation to the pre-existing light task, we can land far in the past).
    
    This is done because update_curr() needs the current task, and we
    might be placing the current task.
    
    The obvious solution is to differentiate between the current and any
    other task; placing the current before we update time, and placing any
    other task after, such that !curr tasks end up at the current moment
    in time, and not in the past.
    
    This commit re-introduces the previously reverted commit:
    
      3a47d512 ("sched/fair: Fix fairness issue on migration")
    
    ... which is now safe to do, after we've also fixed another
    underlying bug first, in:
    
      sched/fair: Prepare to fix fairness problems on migration
    
    and cleaned up other details in the migration code:
    
      sched/core: Kill sched_class::task_waking
    Reported-by: default avatarPavan Kondeti <pkondeti@codeaurora.org>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    2f950354
fair.c 228 KB