• Chandan Rajendra's avatar
    do_direct_IO: Use inode->i_blkbits to compute block count to be cleaned · dd545b52
    Chandan Rajendra authored
    The code currently uses sdio->blkbits to compute the number of blocks to
    be cleaned. However sdio->blkbits is derived from the logical block size
    of the underlying block device (Refer to the definition of
    do_blockdev_direct_IO()). Due to this, generic/299 test would rarely
    fail when executed on an ext4 filesystem with 64k as the block size and
    when using a virtio based disk (having 512 byte as the logical block
    size) inside a kvm guest.
    
    This commit fixes the bug by using inode->i_blkbits to compute the
    number of blocks to be cleaned.
    Signed-off-by: default avatarChandan Rajendra <chandan@linux.vnet.ibm.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    
    Fixed up by Jeff Moyer to only use/evaluate inode->i_blkbits once,
    to avoid issues with block size changes with IO in flight.
    Signed-off-by: default avatarJens Axboe <axboe@fb.com>
    dd545b52
direct-io.c 38.3 KB