• Jens Axboe's avatar
    mpage: add argument structure for do_mpage_readpage() · 357c1206
    Jens Axboe authored
    Patch series "Submit ->readpages() IO as read-ahead", v4.
    
    The only caller of ->readpages() is from read-ahead, yet we don't submit
    IO flagged with REQ_RAHEAD.  This means we don't see it in blktrace, for
    instance, which is a shame.  Additionally, it's preventing further
    functional changes in the block layer for deadling with read-ahead more
    intelligently.  We already make assumptions about ->readpages() just
    being for read-ahead in the mpage implementation, using
    readahead_gfp_mask(mapping) as out GFP mask of choice.
    
    This small series fixes up mpage_readpages() to submit with REQ_RAHEAD,
    which takes care of file systems using mpage_readpages().  The first
    patch is a prep patch, that makes do_mpage_readpage() take an argument
    structure.
    
    This patch (of 4):
    
    We're currently passing 8 arguments to this function, clean it up a bit
    by packing the arguments in an args structure we pass to it.
    
    No intentional functional changes in this patch.
    
    [akpm@linux-foundation.org: coding-style fixes]
    Link: http://lkml.kernel.org/r/20180621010725.17813-2-axboe@kernel.dkSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
    Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Theodore Ts'o <tytso@mit.edu>
    Cc: Chris Mason <clm@fb.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    357c1206
mpage.c 20.9 KB