• Nicholas Kazlauskas's avatar
    drm/amd/display: Enable fast plane updates when state->allow_modeset = true · 37fb6e8a
    Nicholas Kazlauskas authored
    [Why]
    Whenever the a modeset is allowed (but not neccessarily required) we
    currently recreate all the planes in the state. Most IGT tests and
    legacy IOCTLs create atomic commits with this flag set, so the pipes
    are often unnecessarily reprogrammed.
    
    Poor performance and stuttering can occur when many of these commits
    are frequently issued.
    
    This flag was needed when the appropriate conditions for checking
    whether the planes needed a reset were not in place, but
    should_reset_plane should cover everything needed now.
    
    [How]
    Drop the check for state->allow_modeset in should_reset_plane.
    
    All planes on a CRTC should reset in the following conditions:
    - The CRTC needs a modeset
    - The CRTC degamma changes
    - Planes are added or removed to the CRTC
    
    These conditions are all covered in should_reset_plane.
    
    We still can't drop the format change check in should_reset_plane since
    fill_dc_plane_info_and_addr isn't called when validating the state, so
    we can't tell if a FULL update is needed or not.
    Signed-off-by: default avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
    Reviewed-by: default avatarDavid Francis <david.francis@amd.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    37fb6e8a
amdgpu_dm.c 198 KB