• Eric Dumazet's avatar
    ifb: add performance flags · 39980292
    Eric Dumazet authored
    Le lundi 03 janvier 2011 à 11:40 -0800, David Miller a écrit :
    > From: Jarek Poplawski <jarkao2@gmail.com>
    > Date: Mon, 3 Jan 2011 20:37:03 +0100
    >
    > > On Sun, Jan 02, 2011 at 09:24:36PM +0100, Eric Dumazet wrote:
    > >> Le mercredi 29 décembre 2010 ?? 00:07 +0100, Jarek Poplawski a écrit :
    > >>
    > >> > Ingress is before vlans handler so these features and the
    > >> > NETIF_F_HW_VLAN_TX flag seem useful for ifb considering
    > >> > dev_hard_start_xmit() checks.
    > >>
    > >> OK, here is v2 of the patch then, thanks everybody.
    > >>
    > >>
    > >> [PATCH v2 net-next-2.6] ifb: add performance flags
    > >>
    > >> IFB can use the full set of features flags (NETIF_F_SG |
    > >> NETIF_F_FRAGLIST | NETIF_F_TSO | NETIF_F_NO_CSUM | NETIF_F_HIGHDMA) to
    > >> avoid unnecessary split of some packets (GRO for example)
    > >>
    > >> Changli suggested to also set vlan_features,
    > >
    > > He also suggested more GSO flags of which especially NETIF_F_TSO6
    > > seems interesting (wrt GRO)?
    >
    > I think at least TSO6 would very much be appropriate here.
    
    Yes, why not, I am only wondering why loopback / dummy (and others ?)
    only set NETIF_F_TSO :)
    
    Since I want to play with ECN, I might also add NETIF_F_TSO_ECN ;)
    
    For other flags, I really doubt it can matter on ifb ?
    
    [PATCH v3 net-next-2.6] ifb: add performance flags
    
    IFB can use the full set of features flags (NETIF_F_SG |
    NETIF_F_FRAGLIST | NETIF_F_TSO | NETIF_F_NO_CSUM | NETIF_F_HIGHDMA) to
    avoid unnecessary split of some packets (GRO for example)
    
    Changli suggested to also set vlan_features, NETIF_F_TSO6,
    NETIF_F_TSO_ECN.
    
    Jarek suggested to add NETIF_F_HW_VLAN_TX as well.
    Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
    Cc: Changli Gao <xiaosuo@gmail.com>
    Cc: Jarek Poplawski <jarkao2@gmail.com>
    Cc: Pawel Staszewski <pstaszewski@itcare.pl>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    39980292
ifb.c 6.32 KB