• Alex,Shi's avatar
    sched: Fix over-scheduling bug · 3c93717c
    Alex,Shi authored
    Commit e7097159 ("sched: Optimize unused cgroup configuration") introduced
    an imbalanced scheduling bug.
    
    If we do not use CGROUP, function update_h_load won't update h_load. When the
    system has a large number of tasks far more than logical CPU number, the
    incorrect cfs_rq[cpu]->h_load value will cause load_balance() to pull too
    many tasks to the local CPU from the busiest CPU. So the busiest CPU keeps
    going in a round robin. That will hurt performance.
    
    The issue was found originally by a scientific calculation workload that
    developed by Yanmin. With that commit, the workload performance drops
    about 40%.
    
     CPU  before    after
    
     00   : 2       : 7
     01   : 1       : 7
     02   : 11      : 6
     03   : 12      : 7
     04   : 6       : 6
     05   : 11      : 7
     06   : 10      : 6
     07   : 12      : 7
     08   : 11      : 6
     09   : 12      : 6
     10   : 1       : 6
     11   : 1       : 6
     12   : 6       : 6
     13   : 2       : 6
     14   : 2       : 6
     15   : 1       : 6
    Reviewed-by: default avatarYanmin zhang <yanmin.zhang@intel.com>
    Signed-off-by: default avatarAlex Shi <alex.shi@intel.com>
    Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
    LKML-Reference: <1276754893.9452.5442.camel@debian>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    3c93717c
sched.c 214 KB