• David Herrmann's avatar
    drm: don't de-authenticate clients on master-close · 3cb01a98
    David Herrmann authored
    If an active DRM-Master closes its device, we deauthenticate all clients
    on that master. However, if an inactive DRM-Master closes its device, we
    do nothing. This is quite inconsistent and breaks several scenarios:
    
     1) If this was used as security mechanism, it fails horribly if a master
        closes a device while VT switched away. Furthermore, none of the few
        drivers using ->master_*() callbacks seems to require it, anyway.
    
     2) If you spawn weston (or any other non-UMS compositor) in background
        while another compositor is active, both will get assigned to the
        same "drm_master" object. If the foreground compositor now exits, all
        clients of both the foreground AND background compositor will be
        de-authenticated leading to unexpected behavior.
    
    Stop this non-sense and keep clients authenticated. We don't do this when
    dropping DRM-Master (i.e., switching VTs) so don't do it on active-close
    either!
    Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: default avatarDavid Herrmann <dh.herrmann@gmail.com>
    3cb01a98
drm_fops.c 14.7 KB