• Gustavo A. R. Silva's avatar
    dm raid1: use struct_size() with kzalloc() · bcd67654
    Gustavo A. R. Silva authored
    One of the more common cases of allocation size calculations is finding
    the size of a structure that has a zero-sized array at the end, along
    with memory for some number of elements for that array. For example:
    
    struct mirror_set {
    	...
            struct mirror mirror[0];
    };
    
    size = sizeof(struct mirror_set) + count * sizeof(struct mirror);
    instance = kzalloc(size, GFP_KERNEL)
    
    Instead of leaving these open-coded and prone to type mistakes, we can
    now use the new struct_size() helper:
    
    instance = kzalloc(struct_size(instance, mirror, count), GFP_KERNEL)
    
    Notice that, in this case, variable len is not necessary, hence it
    is removed.
    
    This code was detected with the help of Coccinelle.
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
    bcd67654
dm-raid1.c 35 KB