• Chuck Lever's avatar
    svcrdma: Skip put_page() when send_reply() fails · 4131e00a
    Chuck Lever authored
    commit 9995237b upstream.
    
    Message from syslogd@klimt at Aug 18 17:00:37 ...
     kernel:page:ffffea0020639b00 count:0 mapcount:0 mapping:          (null) index:0x0
    Aug 18 17:00:37 klimt kernel: flags: 0x2fffff80000000()
    Aug 18 17:00:37 klimt kernel: page dumped because: VM_BUG_ON_PAGE(page_ref_count(page) == 0)
    
    Aug 18 17:00:37 klimt kernel: kernel BUG at /home/cel/src/linux/linux-2.6/include/linux/mm.h:445!
    Aug 18 17:00:37 klimt kernel: RIP: 0010:[<ffffffffa05c21c1>] svc_rdma_sendto+0x641/0x820 [rpcrdma]
    
    send_reply() assigns its page argument as the first page of ctxt. On
    error, send_reply() already invokes svc_rdma_put_context(ctxt, 1);
    which does a put_page() on that very page. No need to do that again
    as svc_rdma_sendto exits.
    
    Fixes: 3e1eeb98 ("svcrdma: Close connection when a send error occurs")
    Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    4131e00a
svc_rdma_sendto.c 19.5 KB