• Chandra Konduru's avatar
    drm/i915: Add NV12 as supported format for sprite plane · 429204f1
    Chandra Konduru authored
    This patch adds NV12 to list of supported formats for sprite plane.
    
    v2: Rebased (me)
    
    v3: Review comments by Ville addressed
    - Removed skl_plane_formats_with_nv12 and added
    NV12 case in existing skl_plane_formats
    - Added the 10bpc RGB formats
    
    v4: Addressed review comments from Clinton A Taylor
    "Why are we adding 10 bit RGB formats with the NV12 series patches?
    Trying to set XR30 or AB30 results in error returned even though
    the modes are advertised for the planes"
    - Removed 10bit RGB formats added previously with NV12 series
    
    v5: Missed the Tested-by/Reviewed-by in the previous series
    Adding the same to commit message in this version.
    Addressed review comments from Clinton A Taylor
    "Why are we adding 10 bit RGB formats with the NV12 series patches?
    Trying to set XR30 or AB30 results in error returned even though
    the modes are advertised for the planes"
    - Previous version has 10bit RGB format removed from VLV formats
    by mistake. Fixing that in this version.
    Removed 10bit RGB formats added previously with NV12 series
    for SKL.
    
    v6: Addressed review comments by Ville
    Restricting the NV12 to BXT and PIPE A and B
    
    v7: Rebased (me)
    
    v8: Rebased (me)
    Restricting NV12 changes to BXT and KBL
    Restricting NV12 changes for plane 0 (overlay)
    
    v9: Rebased (me)
    
    v10: Addressed review comments from Maarten.
    Adding NV12 to skl_plane_formats itself.
    
    v11: Addressed review comments from Shashank Sharma
    
    v12: Addressed review comments from Shashank Sharma
    Made the condition in intel_sprite_plane_create
    simple and easy to read as suggested.
    
    v13: Adding reviewed by tag from Shashank Sharma
    Addressed review comments from Juha-Pekka Heikkila
    "NV12 not to be supported by SKL"
    
    v14: Addressed review comments from Ville
    Added skl_planar_formats to include NV12
    and a check skl_plane_has_planar in sprite create
    Added NV12 format to skl_mod_supported. These were
    review comments from Kristian Høgsberg <hoegsberg@gmail.com>
    
    v15: Added reviewed by from Juha-Pekka Heikkila
    
    v16: Rebased the series
    
    v17: Added all tiling under mod supported for NV12
    Credits to Megha Aggarwal
    
    v18: Added RB by Maarten and Kristian
    
    v19: Addressed review comments from Maarten
    Made modification to skl_mod_supported
    
    Credits-to: Megha Aggarwal <megha.aggarwal@intel.com>
    Credits-to: Kristian Høgsberg <hoegsberg@gmail.com>
    Reviewed-by: default avatarKristian Høgsberg <hoegsberg@gmail.com>
    Reviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Tested-by: default avatarClinton Taylor <clinton.a.taylor@intel.com>
    Reviewed-by: default avatarJuha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
    Reviewed-by: default avatarShashank Sharma <shashank.sharma@intel.com>
    Reviewed-by: default avatarClinton Taylor <clinton.a.taylor@intel.com>
    Signed-off-by: default avatarChandra Konduru <chandra.konduru@intel.com>
    Signed-off-by: default avatarNabendu Maiti <nabendu.bikash.maiti@intel.com>
    Signed-off-by: default avatarVidya Srinivas <vidya.srinivas@intel.com>
    Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/1526074397-10457-7-git-send-email-vidya.srinivas@intel.com
    429204f1
intel_sprite.c 45.7 KB