• Nathan Lynch's avatar
    powerpc/pseries: correctly track irq state in default idle · 92c94dfb
    Nathan Lynch authored
    prep_irq_for_idle() is intended to be called before entering
    H_CEDE (and it is used by the pseries cpuidle driver). However the
    default pseries idle routine does not call it, leading to mismanaged
    lazy irq state when the cpuidle driver isn't in use. Manifestations of
    this include:
    
    * Dropped IPIs in the time immediately after a cpu comes
      online (before it has installed the cpuidle handler), making the
      online operation block indefinitely waiting for the new cpu to
      respond.
    
    * Hitting this WARN_ON in arch_local_irq_restore():
    	/*
    	 * We should already be hard disabled here. We had bugs
    	 * where that wasn't the case so let's dbl check it and
    	 * warn if we are wrong. Only do that when IRQ tracing
    	 * is enabled as mfmsr() can be costly.
    	 */
    	if (WARN_ON_ONCE(mfmsr() & MSR_EE))
    		__hard_irq_disable();
    
    Call prep_irq_for_idle() from pseries_lpar_idle() and honor its
    result.
    
    Fixes: 363edbe2 ("powerpc: Default arch idle could cede processor on pseries")
    Signed-off-by: default avatarNathan Lynch <nathanl@linux.ibm.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20190910225244.25056-1-nathanl@linux.ibm.com
    92c94dfb
setup.c 26.7 KB