• Petr Mladek's avatar
    livepatch: Proper error handling in the shadow variables selftest · 49ee4dd2
    Petr Mladek authored
    Add proper error handling when allocating or getting shadow variables
    in the selftest. It prevents an invalid pointer access in some situations.
    It shows the good programming practice in the others.
    
    The error codes are just the best guess and specific for this particular
    test. In general, klp_shadow_alloc() returns NULL also when the given
    shadow variable has already been allocated. In addition, both
    klp_shadow_alloc() and klp_shadow_get_or_alloc() might fail from
    other reasons when the constructor fails.
    
    Note, that the error code is not really important even in the real life.
    The use of shadow variables should be transparent for the original
    livepatched code.
    Acked-by: default avatarMiroslav Benes <mbenes@suse.cz>
    Acked-by: default avatarJoe Lawrence <joe.lawrence@redhat.com>
    Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
    49ee4dd2
test_klp_shadow_vars.c 6.33 KB