• Arnaldo Carvalho de Melo's avatar
    perf record: Do not ask for precise_ip with --no-samples · 4b4cd503
    Arnaldo Carvalho de Melo authored
    When the user doesn't specify an event with -e/--event, 'perf record'
    will use as a default the "cycles" event with the highest level of
    precision in perf_event_attr.precise_ip, but --no-samples, if present,
    is incompatible with precise_ip != 0, so use the newly introduced
    __perf_event__add_default(precise = false) to fix that:
    
    Before:
    
      # perf record -n usleep 1
      Please consider tweaking /proc/sys/kernel/perf_event_max_sample_rate.
      Error:
      The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (cycles:ppp).
      /bin/dmesg may provide additional information.
      No CONFIG_PERF_EVENTS=y kernel support configured?
      #
    
    After:
    
      # perf record -n usleep 1
      Please consider tweaking /proc/sys/kernel/perf_event_max_sample_rate.
      [ perf record: Woken up 1 times to write data ]
      [ perf record: Captured and wrote 0.018 MB perf.data ]
      [root@jouet /]# perf evlist -v
      cycles: size: 112, sample_type: IP|TID|TIME|PERIOD, disabled: 1, inherit: 1, mmap: 1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
      [root@jouet /]#
    Reported-by: default avatarJiri Olsa <jolsa@kernel.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Wang Nan <wangnan0@huawei.com>
    Link: http://lkml.kernel.org/n/tip-q991fw6s6rhjvrd5ye4t7qom@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    4b4cd503
builtin-record.c 48.8 KB