• Miquel Raynal's avatar
    mtd: partitions: fix unbalanced of_node_get/put() · 85516a98
    Miquel Raynal authored
    While at first mtd_part_of_parse() would just call
    of_get_chil_by_name(), it has been patched to deal with sub-partitions
    and will now directly manipulate the node returned by mtd_get_of_node()
    if the MTD device is a partition.
    
    A of_node_put() was a bit below in the code, to balance the
    of_get_child_by_name(). However, despite its name, mtd_get_of_node()
    does not take a reference on the OF node. It is a simple helper hiding
    some pointer logic to retrieve the OF node related to an MTD
    device.
    
    The direct effect of such unbalanced reference counting is visible by
    rmmod'ing any module that would have added MTD partitions:
    
        OF: ERROR: Bad of_node_put() on <of_path_to_partition>
    
    As it seems normal to get a reference on the OF node during the
    of_property_for_each_string() that follows, add a call to
    of_node_get() when relevant.
    
    Fixes: 76a83225 ("mtd: partitions: use DT info for parsing partitions with "compatible" prop")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
    Signed-off-by: default avatarBoris Brezillon <boris.brezillon@bootlin.com>
    85516a98
mtdpart.c 27.6 KB