• wuxu.wu's avatar
    spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls · 19b61392
    wuxu.wu authored
    dw_spi_irq() and dw_spi_transfer_one concurrent calls.
    
    I find a panic in dw_writer(): txw = *(u8 *)(dws->tx), when dw->tx==null,
    dw->len==4, and dw->tx_end==1.
    
    When tpm driver's message overtime dw_spi_irq() and dw_spi_transfer_one
    may concurrent visit dw_spi, so I think dw_spi structure lack of protection.
    
    Otherwise dw_spi_transfer_one set dw rx/tx buffer and then open irq,
    store dw rx/tx instructions and other cores handle irq load dw rx/tx
    instructions may out of order.
    
    	[ 1025.321302] Call trace:
    	...
    	[ 1025.321319]  __crash_kexec+0x98/0x148
    	[ 1025.321323]  panic+0x17c/0x314
    	[ 1025.321329]  die+0x29c/0x2e8
    	[ 1025.321334]  die_kernel_fault+0x68/0x78
    	[ 1025.321337]  __do_kernel_fault+0x90/0xb0
    	[ 1025.321346]  do_page_fault+0x88/0x500
    	[ 1025.321347]  do_translation_fault+0xa8/0xb8
    	[ 1025.321349]  do_mem_abort+0x68/0x118
    	[ 1025.321351]  el1_da+0x20/0x8c
    	[ 1025.321362]  dw_writer+0xc8/0xd0
    	[ 1025.321364]  interrupt_transfer+0x60/0x110
    	[ 1025.321365]  dw_spi_irq+0x48/0x70
    	...
    Signed-off-by: default avatarwuxu.wu <wuxu.wu@huawei.com>
    Link: https://lore.kernel.org/r/1577849981-31489-1-git-send-email-wuxu.wu@huawei.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    19b61392
spi-dw.h 6.31 KB