• Axel Lin's avatar
    regulator: s5m8767: Properly handle gpio_request failure · 5febb3c9
    Axel Lin authored
    Convert to devm_gpio_request to save a few error handling code.
    
    This patch properly handle the gpio_request failure, we should return error
    when gpio_request fails rather than just show warning.
    
    I think one of the reason we got -EBUSY is because current code does not free
    gpios in s5m8767_pmic_remove(). So it got -EBUSY when reload the module.
    
    Yest another reason is in current code if gpio_request() returns error,
    the rest of the code still calls gpio_direction_output to config buck_gpios
    and buck_ds gpios. This looks wrong to me.
    Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
    Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
    5febb3c9
s5m8767.c 20.7 KB