• Jon Hunter's avatar
    mmc: tegra: Only advertise UHS modes if IO regulator is present · 4f6aa326
    Jon Hunter authored
    To support UHS modes for Tegra an external regulator must be present
    to adjust the IO voltage accordingly. Even if the regulator is not
    present but the host supports the UHS modes and the device supports the
    UHS modes, then we will attempt to switch to a high-speed mode. Without
    an external regulator, Tegra will fail to switch to the high-speed
    mode.
    
    It has been found that with some SD cards, that once it has been switch
    to operate at a high-speed mode, all subsequent commands issues to the
    card will fail and so it will not be possible to switch back to a non
    high-speed mode and so the SD card initialisation will fail.
    
    The SDHCI core does not require that the host have an external regulator
    when switching to UHS modes and therefore, the Tegra SDHCI host
    controller should only advertise the UHS modes as being supported if the
    regulator for the IO voltage is present. Fortunately, Tegra has a vendor
    specific register which can be used to control which modes are
    advertised via the SDHCI_CAPABILITIES register. Hence, if there is no IO
    voltage regulator available for the Tegra SDHCI host, then don't
    advertise the UHS modes.
    
    Note that if the regulator is not available, we also don't advertise that
    the SDHCI is compatible with v3.0 of the SDHCI specification because
    this will read the SDHCI_CAPABILITIES_1 register which will enable other
    UHS modes.
    
    This fixes commit 7ad2ed1d ("mmc: tegra: enable UHS-I modes") which
    enables UHS mode without checking if the board can support them.
    
    Fixes: 7ad2ed1d ("mmc: tegra: enable UHS-I modes")
    Signed-off-by: default avatarJon Hunter <jonathanh@nvidia.com>
    Acked-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
    Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
    4f6aa326
sdhci-tegra.c 14.4 KB