• Julia Lawall's avatar
    thermal: int340x_thermal: use permission-specific DEVICE_ATTR variants · 5184eeb3
    Julia Lawall authored
    Use DEVICE_ATTR_RW for read-write attributes.  This simplifies the
    source code, improves readbility, and reduces the chance of
    inconsistencies.
    
    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @rw@
    declarer name DEVICE_ATTR;
    identifier x,x_show,x_store;
    @@
    
    DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);
    
    @script:ocaml@
    x << rw.x;
    x_show << rw.x_show;
    x_store << rw.x_store;
    @@
    
    if not (x^"_show" = x_show && x^"_store" = x_store)
    then Coccilib.include_match false
    
    @@
    declarer name DEVICE_ATTR_RW;
    identifier rw.x,rw.x_show,rw.x_store;
    @@
    
    - DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);
    + DEVICE_ATTR_RW(x);
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: default avatarZhang Rui <rui.zhang@intel.com>
    5184eeb3
int3400_thermal.c 7.83 KB