• Arnaldo Carvalho de Melo's avatar
    perf annotate browser: Add visual cues on jump lines · 51a0d455
    Arnaldo Carvalho de Melo authored
    Using up/down arrows just before the instruction, replacing the actual chars
    with approximations to avoid mail encoding snafus:
    
    avtab_search_node
        0.00 |      push   %rbp
        0.00 |      mov    %rsp,%rbp
        0.00 |      callq  mcount
        0.00 |      movzwl 0x6(%rsi),%edx
        0.00 |      and    $0x7fff,%dx
        0.00 |      test   %rdi,%rdi
        0.00 |    v jne    20
        0.00 | 17:  xor    %eax,%eax
        0.00 | 19:  leaveq
        0.00 |      retq
        0.00 |      nopl   0x0(%rax,%rax,1)
        0.00 | 20:  mov    (%rdi),%rax
        0.00 |      test   %rax,%rax
        0.00 |    ^ je     17
        0.00 |      movzwl (%rsi),%ecx
        0.00 |      movzwl 0x2(%rsi),%r9d
        0.00 |      movzwl 0x4(%rsi),%r8d
        0.00 |      movzwl %cx,%esi
        0.00 |      movzwl %r9w,%r10d
        0.00 |      shl    $0x9,%esi
        0.00 |      lea    (%rsi,%r10,4),%esi
        0.00 |      lea    (%r8,%rsi,1),%esi
        0.00 |      and    0x10(%rdi),%si
        0.00 |      movzwl %si,%esi
        0.00 |      mov    (%rax,%rsi,8),%rax
        0.00 |      test   %rax,%rax
        0.00 |    ^ je     19
        0.00 |      nopw   0x0(%rax,%rax,1)
        0.00 | 60:  cmp    %cx,(%rax)
        0.00 |    v jne    7e
        0.00 |      cmp    %r9w,0x2(%rax)
        0.00 |    v jne    7e
        0.00 |      cmp    %r8w,0x4(%rax)
        0.00 |    v jne    79
        0.00 |      test   %dx,0x6(%rax)
        0.00 |    ^ jne    19
        0.00 | 79:  cmp    %r8w,0x4(%rax)
       93.04 | 7e:^ ja     17
        2.53 |      mov    0x10(%rax),%rax
        4.43 |      test   %rax,%rax
        0.00 |    ^ jne    60
        0.00 |      leaveq
        0.00 |      retq
    
    Next low hanging fruit is to use left arrow for retqs, then work on clearling
    marking loops.
    Requested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-hkx848wdbs6n7bcp3ymr9yus@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    51a0d455
annotate.c 18.2 KB