• Daniel Vetter's avatar
    drm/vkms: Use devm_drm_dev_alloc · 53d77aaa
    Daniel Vetter authored
    This means we also need to slightly restructure the exit code, so that
    final cleanup of the drm_device is triggered by unregistering the
    platform device. Note that devres is both clean up when the driver is
    unbound (not the case for vkms, we don't bind), and also when unregistering
    the device (very much the case for vkms). Therefore we can rely on devres
    even though vkms isn't a proper platform device driver.
    
    This also somewhat untangles the load code, since the drm and platform device
    setup are no longer interleaved, but two distinct steps.
    
    v2: use devres_open/release_group so we can use devm without real
    hacks in the driver core or having to create an entire fake bus for
    testing drivers. Might want to extract this into helpers eventually,
    maybe as a mock_drm_dev_alloc or test_drm_dev_alloc.
    
    v3: Only deref vkms_device after checking it (Melissa)
    Reviewed-by: default avatarMelissa Wen <melissa.srw@gmail.com>
    Cc: Melissa Wen <melissa.srw@gmail.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
    Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
    Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200909091833.440548-1-daniel.vetter@ffwll.ch
    53d77aaa
vkms_drv.c 5.45 KB