• Jiri Hladky's avatar
    x86: fix bug in arch/i386/lib/delay.c file, delay_loop function · e01b70ef
    Jiri Hladky authored
    when trying to understand how Bogomips are implemented I have found a
    bug in arch/i386/lib/delay.c file, delay_loop function.
    
    The function fails for loops > 2^31+1. It because SF is set when dec
    returns numbers > 2^31.
    
    The fix is to use jnz instruction instead of jns (and add one decl
    instruction to the end to have exactly the same number of loops as in
    original version).
    
    Martin Mares observed:
    
    > It is a long time since I have hacked that file, but you should definitely
    > make sure that the function is never called with a zero argument. In such
    > case, the original version made just a single pass, but your version
    > makes 2^32 of them.
    
    fixed that.
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    e01b70ef
delay_32.c 2.79 KB