• Colin Cross's avatar
    OMAP2+: PM: SmartReflex: use put_sync_suspend for IRQ-safe disabling · 98333b3d
    Colin Cross authored
    omap_sr_disable_reset_volt is called with irqs off in omapx_enter_sleep,
    as part of idle sequence, this eventually calls sr_disable and
    pm_runtime_put_sync. pm_runtime_put_sync calls rpm_idle, which will
    enable interrupts in order to call the callback. In this short interval
    when interrupts are enabled, scenarios such as the following can occur:
    while interrupts are enabled, the timer interrupt that is supposed to
    wake the device out of idle occurs and is acked, so when the CPU finally
    goes to off, the timer is already gone, missing a wakeup event.
    
    Further, as the documentation for runtime states:"
     However, subsystems can use the pm_runtime_irq_safe() helper function
     to tell the PM core that a device's ->runtime_suspend() and ->runtime_resume()
     callbacks should be invoked in atomic context with interrupts disabled
     (->runtime_idle() is still invoked the default way)."
    
    Hence, replace pm_runtime_put_sync with pm_runtime_put_sync_suspend
    to invoke the suspend handler and shut off the fclk for SmartReflex
    module instead of using the idle handler in interrupt disabled context.
    Signed-off-by: default avatarNishanth Menon <nm@ti.com>
    Signed-off-by: default avatarColin Cross <ccross@google.com>
    [khilman@ti.com: minor Subject edits]
    Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
    98333b3d
smartreflex.c 27.9 KB