• Kees Cook's avatar
    selftests: Move test output to diagnostic lines · 5c069b6d
    Kees Cook authored
    This changes the selftest output so that each test's output is prefixed
    with "# " as a TAP "diagnostic line".
    
    This creates a bit of a kernel-specific TAP dialect where the diagnostics
    precede the results. The TAP spec isn't entirely clear about this, though,
    so I think it's the correct solution so as to keep interactive runs making
    sense. If the output _followed_ the result line in the spec-suggested
    YAML form, each test would dump all of its output at once instead of as
    it went, making debugging harder.
    
    This does, however, solve the recursive TAP output problem, as sub-tests
    will simply be prefixed by "# ". Parsing sub-tests becomes a simple
    problem of just removing the first two characters of a given top-level
    test's diagnostic output, and parsing the results.
    
    Note that the shell construct needed to both get an exit code from
    the first command in a pipe and still filter the pipe (to add the "# "
    prefix) uses a POSIX solution rather than the bash "pipefail" option
    which is not supported by dash.
    
    Since some test environments may have a very minimal set of utilities
    available, the new prefixing code will fall back to doing line-at-a-time
    prefixing if perl and/or stdbuf are not available.
    Signed-off-by: default avatarKees Cook <keescook@chromium.org>
    Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
    5c069b6d
lib.mk 4.86 KB