• Nathan Chancellor's avatar
    MIPS/ptrace: Update mips_get_syscall_arg's return type · 077ff3be
    Nathan Chancellor authored
    clang warns:
    
    arch/mips/include/asm/syscall.h:136:3: error: variable 'ret' is
    uninitialized when used here [-Werror,-Wuninitialized]
                    ret |= mips_get_syscall_arg(args++, task, regs, i++);
                    ^~~
    arch/mips/include/asm/syscall.h:129:9: note: initialize the variable
    'ret' to silence this warning
            int ret;
                   ^
                    = 0
    1 error generated.
    
    It's not wrong; however, it's not an issue in practice because ret is
    only assigned to, not read from. ret could just be initialized to zero
    but looking into it further, ret has been unused since it was first
    added in 2012 so just get rid of it and update mips_get_syscall_arg's
    return type since none of the return values are ever checked. If it is
    ever needed again, this commit can be reverted and ret can be properly
    initialized.
    
    Fixes: c0ff3c53 ("MIPS: Enable HAVE_ARCH_TRACEHOOK.")
    Link: https://github.com/ClangBuiltLinux/linux/issues/604Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
    Cc: Ralf Baechle <ralf@linux-mips.org>
    Cc: James Hogan <jhogan@kernel.org>
    Cc: Nick Desaulniers <ndesaulniers@google.com>
    Cc: linux-mips@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Cc: clang-built-linux@googlegroups.com
    077ff3be
syscall.h 3.62 KB