• Chuck Lever's avatar
    NSM: Make sure to return an error if the SM_MON call result is not zero · 5d254b11
    Chuck Lever authored
    The nsm_monitor() function reports an error and does not set sm_monitored
    if the SM_MON upcall reply has a non-zero result code, but nsm_monitor()
    does not return an error to its caller in this case.
    
    Since sm_monitored is not set, the upcall is retried when the next NLM
    request invokes nsm_monitor().  However, that may not come for a while.
    In the meantime, at least one NLM request will potentially proceed
    without the peer being monitored properly.
    
    Have nsm_monitor() return an error if the result code is non-zero.
    This will cause all NLM requests to fail immediately if the upcall
    completed successfully but rpc.statd returned an error.
    
    This may be inconvenient in some cases (for example if rpc.statd
    cannot complete a proper DNS reverse lookup of the hostname), but will
    make the reboot monitoring service more robust by forcing such issues
    to be corrected by an admin.
    Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
    5d254b11
mon.c 6.77 KB