• Douglas Anderson's avatar
    arm64: dts: sdm845: Fix xo_board clock name and speed · 5ea3939c
    Douglas Anderson authored
    The RPMh clock driver assumes that the xo_board clock is named
    "xo_board", not "xo-board".  Add a "clock-output-names" property to
    the device tree to get the right name.
    
    Also add the proper speed for the xo-clock as 38400000.  This is
    internally divided in RPMh clock driver to get "bi_tcxo" at 19200000.
    
    After this change the clock tree in /sys/kernel/debug/clk/clk_summary
    looks much better.
    
    NOTES:
    - Technically you could argue that this clock could belong in board
      .dts files, not in the SoC one.  However at the moment it's believed
      that 100% of sdm845 boards will have an external clock at 38.4.  It
      can always be moved later if necessary.
    - We could rename the "xo-board" device tree node to "xo_board" to
      achieve the same effect as this patch.  Presumably device-tree folks
      would rather keep node names using dashes though.
    - We could change the RPMh clock driver to use a dash to achieve the
      same effect as this patch, but all other clocks in the clock tree
      use underscores.  It seems silly to change just this one.
    
    Fixes: 7bafa643647f ("arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP")
    Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
    Signed-off-by: default avatarAndy Gross <andy.gross@linaro.org>
    5ea3939c
sdm845.dtsi 6.57 KB