• Ard Biesheuvel's avatar
    ARM: 8680/1: boot/compressed: fix inappropriate Thumb2 mnemonic for __nop · 60ce2858
    Ard Biesheuvel authored
    Commit 06a4b6d0 ("ARM: 8677/1: boot/compressed: fix decompressor
    header layout for v7-M") fixed an issue in the layout of the header
    of the compressed kernel image that was caused by the assembler
    emitting narrow opcodes for 'mov r0, r0', and for this reason, the
    mnemonic was updated to use the W() macro, which will append the .w
    suffix (which forces a wide encoding) if required, i.e., when building
    the kernel in Thumb2 mode.
    
    However, this failed to take into account that on Thumb2 kernels built
    for CPUs that are also ARM capable, the entry point is entered in ARM
    mode, and so the instructions emitted here will be ARM instructions
    that only exist in a wide encoding to begin with, which is why the
    assembler rejects the .w suffix here and aborts the build with the
    following message:
    
      head.S: Assembler messages:
      head.S:132: Error: width suffixes are invalid in ARM mode -- `mov.w r0,r0'
    
    So replace the W(mov) with separate ARM and Thumb2 instructions, where
    the latter will only be used for THUMB2_ONLY builds.
    
    Fixes: 06a4b6d0 ("ARM: 8677/1: boot/compressed: fix decompressor ...")
    Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
    Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
    60ce2858
efi-header.S 3.79 KB