• Arnaldo Carvalho de Melo's avatar
    perf ui browser: Add ->rows to disambiguate from ->height · 62c95ae3
    Arnaldo Carvalho de Melo authored
    The ui_browser->height is about the whole browser "window", including
    any header, status lines or any other space needed for some "Yes", "No",
    etc buttons a descendent browser, like hist_browser, may have.
    
    Since the navigation is done mostly on the ui_browser methods, it needs
    to know how many rows are on the screen, while details about what other
    components are, say, if a header (that may be composed of multiple
    lines, etc) is present.
    
    Besides this we'll need to add a ui_browser->refresh_dimensions() hook
    so that browsers like hist_browser can update ->rows in response to
    screen resizes, this will come in a follow up patch.
    
    This patch just adds ->rows and updates it when updating ->height, keeps
    using ->height for the only other widget that can come with ui_browser,
    the scrollbar, that goes on using all the height on the rightmost column
    in the screen, using ->rows for the keyboard navigation needs.
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Don Zickus <dzickus@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-xexmwg1mv7u03j5imn66jdak@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    62c95ae3
hists.c 50.2 KB