• David S. Miller's avatar
    Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf · 69138b34
    David S. Miller authored
    Daniel Borkmann says:
    
    ====================
    pull-request: bpf 2020-07-31
    
    The following pull-request contains BPF updates for your *net* tree.
    
    We've added 5 non-merge commits during the last 21 day(s) which contain
    a total of 5 files changed, 126 insertions(+), 18 deletions(-).
    
    The main changes are:
    
    1) Fix a map element leak in HASH_OF_MAPS map type, from Andrii Nakryiko.
    
    2) Fix a NULL pointer dereference in __btf_resolve_helper_id() when no
       btf_vmlinux is available, from Peilin Ye.
    
    3) Init pos variable in __bpfilter_process_sockopt(), from Christoph Hellwig.
    
    4) Fix a cgroup sockopt verifier test by specifying expected attach type,
       from Jean-Philippe Brucker.
    
    Note that when net gets merged into net-next later on, there is a small
    merge conflict in kernel/bpf/btf.c between commit 5b801dfb ("bpf: Fix
    NULL pointer dereference in __btf_resolve_helper_id()") from the bpf tree
    and commit 138b9a05 ("bpf: Remove btf_id helpers resolving") from the
    net-next tree.
    
    Resolve as follows: remove the old hunk with the __btf_resolve_helper_id()
    function. Change the btf_resolve_helper_id() so it actually tests for a
    NULL btf_vmlinux and bails out:
    
    int btf_resolve_helper_id(struct bpf_verifier_log *log,
                              const struct bpf_func_proto *fn, int arg)
    {
            int id;
    
            if (fn->arg_type[arg] != ARG_PTR_TO_BTF_ID || !btf_vmlinux)
                    return -EINVAL;
            id = fn->btf_id[arg];
            if (!id || id > btf_vmlinux->nr_types)
                    return -EINVAL;
            return id;
    }
    
    Let me know if you run into any others issues (CC'ing Jiri Olsa so he's in
    the loop with regards to merge conflict resolution).
    ====================
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    69138b34
bpfilter_kern.c 2.58 KB