• Christian Brauner's avatar
    netns: send uevent messages · 692ec06d
    Christian Brauner authored
    This patch adds a receive method to NETLINK_KOBJECT_UEVENT netlink sockets
    to allow sending uevent messages into the network namespace the socket
    belongs to.
    
    Currently non-initial network namespaces are already isolated and don't
    receive uevents. There are a number of cases where it is beneficial for a
    sufficiently privileged userspace process to send a uevent into a network
    namespace.
    
    One such use case would be debugging and fuzzing of a piece of software
    which listens and reacts to uevents. By running a copy of that software
    inside a network namespace, specific uevents could then be presented to it.
    More concretely, this would allow for easy testing of udevd/ueventd.
    
    This will also allow some piece of software to run components inside a
    separate network namespace and then effectively filter what that software
    can receive. Some examples of software that do directly listen to uevents
    and that we have in the past attempted to run inside a network namespace
    are rbd (CEPH client) or the X server.
    
    Implementation:
    The implementation has been kept as simple as possible from the kernel's
    perspective. Specifically, a simple input method uevent_net_rcv() is added
    to NETLINK_KOBJECT_UEVENT sockets which completely reuses existing
    af_netlink infrastructure and does neither add an additional netlink family
    nor requires any user-visible changes.
    
    For example, by using netlink_rcv_skb() we can make use of existing netlink
    infrastructure to report back informative error messages to userspace.
    
    Furthermore, this implementation does not introduce any overhead for
    existing uevent generating codepaths. The struct netns got a new uevent
    socket member that records the uevent socket associated with that network
    namespace including its position in the uevent socket list. Since we record
    the uevent socket for each network namespace in struct net we don't have to
    walk the whole uevent socket list. Instead we can directly retrieve the
    relevant uevent socket and send the message. At exit time we can now also
    trivially remove the uevent socket from the uevent socket list. This keeps
    the codepath very performant without introducing needless overhead and even
    makes older codepaths faster.
    
    Uevent sequence numbers are kept global. When a uevent message is sent to
    another network namespace the implementation will simply increment the
    global uevent sequence number and append it to the received uevent. This
    has the advantage that the kernel will never need to parse the received
    uevent message to replace any existing uevent sequence numbers. Instead it
    is up to the userspace process to remove any existing uevent sequence
    numbers in case the uevent message to be sent contains any.
    
    Security:
    In order for a caller to send uevent messages to a target network namespace
    the caller must have CAP_SYS_ADMIN in the owning user namespace of the
    target network namespace. Additionally, any received uevent message is
    verified to not exceed size UEVENT_BUFFER_SIZE. This includes the space
    needed to append the uevent sequence number.
    
    Testing:
    This patch has been tested and verified to work with the following udev
    implementations:
    1. CentOS 6 with udevd version 147
    2. Debian Sid with systemd-udevd version 237
    3. Android 7.1.1 with ueventd
    Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    692ec06d
kobject_uevent.c 17 KB