• Ido Schimmel's avatar
    mlxsw: spectrum_router: Fix NULL pointer dereference · 6b27c8ad
    Ido Schimmel authored
    In case a VLAN device is enslaved to a bridge we shouldn't create a
    router interface (RIF) for it when it's configured with an IP address.
    This is already handled by the driver for other types of netdevs, such
    as physical ports and LAG devices.
    
    If this IP address is then removed and the interface is subsequently
    unlinked from the bridge, a NULL pointer dereference can happen, as the
    original 802.1d FID was replaced with an rFID which was then deleted.
    
    To reproduce:
    $ ip link set dev enp3s0np9 up
    $ ip link add name enp3s0np9.111 link enp3s0np9 type vlan id 111
    $ ip link set dev enp3s0np9.111 up
    $ ip link add name br0 type bridge
    $ ip link set dev br0 up
    $ ip link set enp3s0np9.111 master br0
    $ ip address add dev enp3s0np9.111 192.168.0.1/24
    $ ip address del dev enp3s0np9.111 192.168.0.1/24
    $ ip link set dev enp3s0np9.111 nomaster
    
    Fixes: 99724c18 ("mlxsw: spectrum: Introduce support for router interfaces")
    Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
    Reported-by: default avatarPetr Machata <petrm@mellanox.com>
    Tested-by: default avatarPetr Machata <petrm@mellanox.com>
    Reviewed-by: default avatarPetr Machata <petrm@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    6b27c8ad
spectrum_router.c 94.8 KB