• Lai Jiangshan's avatar
    KVM: x86: Intercept LA57 to inject #GP fault when it's reserved · 6e1d849f
    Lai Jiangshan authored
    Unconditionally intercept changes to CR4.LA57 so that KVM correctly
    injects a #GP fault if the guest attempts to set CR4.LA57 when it's
    supported in hardware but not exposed to the guest.
    
    Long term, KVM needs to properly handle CR4 bits that can be under guest
    control but also may be reserved from the guest's perspective.  But, KVM
    currently sets the CR4 guest/host mask only during vCPU creation, and
    reworking flows to change that will take a bit of elbow grease.
    
    Even if/when generic support for intercepting reserved bits exists, it's
    probably not worth letting the guest set CR4.LA57 directly.  LA57 can't
    be toggled while long mode is enabled, thus it's all but guaranteed to
    be set once (maybe twice, e.g. by BIOS and kernel) during boot and never
    touched again.  On the flip side, letting the guest own CR4.LA57 may
    incur extra VMREADs.  In other words, this temporary "hack" is probably
    also the right long term fix.
    
    Fixes: fd8cb433 ("KVM: MMU: Expose the LA57 feature to VM.")
    Cc: stable@vger.kernel.org
    Cc: Lai Jiangshan <jiangshanlai@gmail.com>
    Signed-off-by: default avatarLai Jiangshan <laijs@linux.alibaba.com>
    [sean: rewrote changelog]
    Signed-off-by: default avatarSean Christopherson <sean.j.christopherson@intel.com>
    Message-Id: <20200930041659.28181-2-sean.j.christopherson@intel.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    6e1d849f
kvm_cache_regs.h 4.81 KB