• Frans Klaver's avatar
    eeepc-laptop: tell sysfs that the disp attribute is write-only · 6fe3a77f
    Frans Klaver authored
    The disp attribute is write-only, but sysfs doesn't know this. Currently
    show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi call
    should fail. This was introduced in 6dff29b6 "eeepc-laptop:
    disp attribute should be write-only". This is not ideal; behaving like
    sysfs is better left to sysfs.
    
    Introduce EEEPC_CREATE_DEVICE_ATTR_WO() to instantiate a write-only
    attribute, and declare the disp attribute with it. Sysfs makes sure
    userspace can only write to disp at all times. This removes the need for
    mimicking the sysfs behavior in show_sys_acpi() and store_sys_acpi(),
    but we'll stick with -EIO, as changing sysfs return values should not be
    taken lightly.
    
    This change also causes EEEPC_CREATE_DEVICE_ATTR() to be used only for
    R/W attributes. This enables us to drop the _mode argument from the
    macro and use DEVICE_ATTR_RW() internally while we're at it. Append _RW
    to the name for readability.
    Signed-off-by: default avatarFrans Klaver <fransklaver@gmail.com>
    Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
    6fe3a77f
eeepc-laptop.c 35.7 KB