• José Roberto de Souza's avatar
    drm/i915/dp: Return the right vswing tables · 70988115
    José Roberto de Souza authored
    DDI ports have its encoders initialized with INTEL_OUTPUT_DDI type and
    later eDP ports that have the type changed to INTEL_OUTPUT_EDP.
    But for all other DDI ports it can drive HDMI or DP depending on what
    user connects to the ports.
    
    ehl_get_combo_buf_trans() and tgl_get_combo_buf_trans() was checking
    for INTEL_OUTPUT_DP that was never true, causing wrong vswing tables
    being used.
    
    So here replacing the INTEL_OUTPUT_DP checks by the valid output types
    that this functions receives as parameters. HDMI cases will be
    correctly handled as it do not use encoder->type, instead it calls the
    functions with INTEL_OUTPUT_HDMI as type parameter and HDMI don't have
    retraining.
    
    v2:
    changed INTEL_OUTPUT_DDI to INTEL_OUTPUT_EDP and INTEL_OUTPUT_HDMI
    
    Fixes: bd3cf6f7 ("drm/i915/dp/tgl+: Update combo phy vswing tables")
    Cc: Clinton A Taylor <clinton.a.taylor@intel.com>
    Cc: Matt Roper <matthew.d.roper@intel.com>
    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
    Signed-off-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200330210044.130510-1-jose.souza@intel.com
    70988115
intel_ddi.c 146 KB