• Gerrit Renker's avatar
    [DCCP] ccid3: Remove redundant statements in ccid3_hc_tx_packet_sent · 70dbd5b0
    Gerrit Renker authored
    This patch removes a switch statement which is redundant since,
     * nothing is done in states TFRC_SSTATE_NO_SENT/TFRC_SSTATE_NO_FBACK
     * it is impossible that the function is called in the state TFRC_SSTATE_TERM, since
           --the function is called, in dccp_write_xmit, after ccid3_hc_tx_send_packet
           --if ccid3_hc_tx_send_packet is called in state TFRC_SSTATE_TERM, it returns
             -EINVAL, which means that ccid3_hc_tx_packet_sent will not be called
    	 (compare dccp_write_xmit)
           --> therefore, this case is logically impossible
     * the remaining state is TFRC_SSTATE_FBACK which conditionally updates t_ipi, t_nom,
       and t_delta. This is a no-op, since
           --t_ipi only changes when feedback is received
           --however, when feedback arrives via ccid3_hc_tx_packet_recv, there is an identical
             code block which performs the same set of operations
           --performing the same set of operations again in ccid3_hc_tx_packet_sent therefore
             does not change anything, since between the time of receiving the last feedback
    	 (and therefore update of t_ipi, t_nom, and t_delta), the value of t_ipi has not
    	 changed
           --since t_ipi has not changed, the values of t_delta and t_nom also do not change,
             they depend fully on t_ipi
    Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
    Acked-by: default avatarIan McDonald <ian.mcdonald@jandi.co.nz>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@mandriva.com>
    70dbd5b0
ccid3.c 35.3 KB