• Nicolas Iooss's avatar
    ceph: do not modify fi->frag in need_reset_readdir() · 0f5aa88a
    Nicolas Iooss authored
    Commit f3c4ebe6 ("ceph: using hash value to compose dentry offset")
    modified "if (fpos_frag(new_pos) != fi->frag)" to "if (fi->frag |=
    fpos_frag(new_pos))" in need_reset_readdir(), thus replacing a
    comparison operator with an assignment one.
    
    This looks like a typo which is reported by clang when building the
    kernel with some warning flags:
    
        fs/ceph/dir.c:600:22: error: using the result of an assignment as a
        condition without parentheses [-Werror,-Wparentheses]
                } else if (fi->frag |= fpos_frag(new_pos)) {
                           ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
        fs/ceph/dir.c:600:22: note: place parentheses around the assignment
        to silence this warning
                } else if (fi->frag |= fpos_frag(new_pos)) {
                                    ^
                           (                             )
        fs/ceph/dir.c:600:22: note: use '!=' to turn this compound
        assignment into an inequality comparison
                } else if (fi->frag |= fpos_frag(new_pos)) {
                                    ^~
                                    !=
    
    Fixes: f3c4ebe6 ("ceph: using hash value to compose dentry offset")
    Signed-off-by: default avatarNicolas Iooss <nicolas.iooss_linux@m4x.org>
    Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
    0f5aa88a
dir.c 40 KB