• Trent Piepho's avatar
    V4L/DVB (10559): bttv: Fix TDA9880 norm setting code · 72134a6d
    Trent Piepho authored
    The code to set the norm for the TDA9880 analog demod was comparing
    btv->norm, an index into the bttv driver's norm array, to V4L2_STD_NTSC,
    which is a bit flag that's part of the V4L2 API.  This doesn't work of
    course and results in the PAL path always being taken.
    
    What's more, it modified the bttv_tvcards[] entries for cards using the
    TDA9880.  This is wrong because changing the norm on one card will also
    affect other cards of the same type.  Writing to bttv_tvcards is also bad
    because it should be read-only or even devinitdata.
    
    Changing the norm would also cause the audio to become unmuted.
    
    Have the code get called for both norm setting and audio input setting
    (which where the gpios are set) to avoid needed to modify bttv_tvcards.
    Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    72134a6d
bttv.h 13 KB