• Geert Uytterhoeven's avatar
    mmc: block: Initialize ret in mmc_blk_issue_drv_op() for MMC_DRV_OP_IOCTL · 7432b49b
    Geert Uytterhoeven authored
    With gcc 4.1.2:
    
        drivers/mmc/core/block.c: In function ‘mmc_blk_issue_drv_op’:
        drivers/mmc/core/block.c:1178: warning: ‘ret’ may be used uninitialized in this function
    
    Indeed, for MMC_DRV_OP_IOCTL, if mq_rq->ioc_count is zero, an
    uninitialized value will be stored in mq_rq->drv_op_result and passed to
    blk_end_request_all().
    
    Can mq_rq->ioc_count be zero?
      - mmc_blk_ioctl_cmd() sets ioc_count to 1, so this is safe,
      - mmc_blk_ioctl_multi_cmd() obtains ioc_count from user space in
        response to the MMC_IOC_MULTI_CMD ioctl, and does allow zero.
    
    Initialize ret to zero to fix this for current and future callers.
    
    Fixes: 0493f6fe ("mmc: block: Move boot partition locking into a driver op")
    Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
    7432b49b
block.c 59.4 KB